Speed up setup #137
Merged
Speed up setup #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests should pass after #136 is merged |
niharikasingh
approved these changes
Jul 29, 2020
| for (i=0; i<tries; i++) { | ||
| const element = await page.$('#daMainQuestion'); | ||
| if (element) { | ||
| console.log("found question on page"); |
There was a problem hiding this comment.
Just want to confirm that these statements are intentionally here, and not leftovers from debugging. Otherwise, looks good.
There was a problem hiding this comment.
Yeah I figured they were nice to have when watching the pipeline running
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.