Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new chart causes Recharts to fail in both new branch and master branch - PR 103 #108

Open
jkoren opened this issue Nov 17, 2023 · 0 comments

Comments

@jkoren
Copy link
Collaborator

jkoren commented Nov 17, 2023

Something strange is occurring which pertains to PR 103

#See comment:
We need to check on the graphs/charts. When those are back to the way they were, we can merge.
Originally posted by @plocket in #103 (comment)

As a test, I created a new repo with epic stack and recharts. jkoren/epic-stack-with-recharts. A simple test scatter graph displayed. So it all worked ok.

Then I created a branch on that repo: revising-charts-for-HEAT

I brought over the three graphs from [PR 103(https://github.com//pull/103) into that new branch.

  1. Heat Load
  2. Standard Deviation of UA
  3. Whole Home UA Comparison

I called them from root.tsx as below.

  <Document nonce={nonce}>
    <SimpleScatterChart />
    <HeatLoad />
    <StandardDeviationOfUA />
    <WholeHomeUAComparison />
  </Document>

The 3 new graphs did not work.
The test scatter graph that had worked did not work now either.

here’s the strange part:
I switched back to the master branch, and the test scatter graph no longer worked there either, even though I made no changes to the master branch.

It seems somehow the Epic stack or Rechart or both got corrupted.

@jkoren jkoren changed the title We need to check on the graphs/charts. When those are back to the way they were, we can merge. Something strange is occurring which pertains to [PR 103](https://github.com/codeforboston/home-energy-analysis-tool/pull/103) Nov 17, 2023
@jkoren jkoren changed the title Something strange is occurring which pertains to [PR 103](https://github.com/codeforboston/home-energy-analysis-tool/pull/103) Adding a chart causes Recharts to fail in both new branch and master branch - [PR 103](https://github.com/codeforboston/home-energy-analysis-tool/pull/103) Nov 30, 2023
@jkoren jkoren changed the title Adding a chart causes Recharts to fail in both new branch and master branch - [PR 103](https://github.com/codeforboston/home-energy-analysis-tool/pull/103) Adding a chart causes Recharts to fail in both new branch and master branch - PR 103 Nov 30, 2023
@jkoren jkoren changed the title Adding a chart causes Recharts to fail in both new branch and master branch - PR 103 Adding a new chart causes Recharts to fail in both new branch and master branch - PR 103 Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant