-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend: Profile Page Tabs as URL Params #364
Frontend: Profile Page Tabs as URL Params #364
Conversation
Build Command ReplacementWith the implementation of this feature, I had to switch the "/profile" page to an SSR page instead of a static page -- this meant that using "scripts": {
"build:dev": "env-cmd -f .env.development next build && next start",
"build:stage": "env-cmd -f .env.staging next build && next start",
"build:prod": "env-cmd -f .env.production next build && next start",
"build:ui": "env-cmd -f .env.ui next build",
}, |
|
frontend/package.json
Outdated
"build:ui": "env-cmd -f .env.ui next build && next export", | ||
"build:dev": "env-cmd -f .env.development next build && next start", | ||
"build:stage": "env-cmd -f .env.staging next build && next start", | ||
"build:prod": "env-cmd -f .env.production next build && next start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these && next start
and add a command "start": "next start"
, or edit Dockerfile.cloud to add a &
to the end of the npm run build:{...
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do both of these things? I've adjusted the build commands to remove next start
from them -- do I need to add & npm run start
to the Dockerfile.cloud RUN command as well?
"scripts": {
"build:dev": "env-cmd -f .env.development next build",
"build:stage": "env-cmd -f .env.staging next build",
"build:prod": "env-cmd -f .env.production next build",
"build:ui": "env-cmd -f .env.ui next build",
"start": "next start",
},
This PR contains some changes that moves the active tab state into the URL, that way the user can navigate to different profile page tabs via the URL, and the app can dynamically switch tabs if it needs to.
Demonstration