Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officer, Agency combined Search #376

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

hrauniya
Copy link
Collaborator

@hrauniya hrauniya commented Apr 23, 2024

-Added alembic migration to set up a Postgres materialized view for the search function to search relevant Officers, Agencies.
-Migration handles insertions, deletions etc. to Agency, Officer Tables, and updates the view necessary for search.
-Search function returns most relevant results according to search terms specified in the function.

Questions:

  • Should the API return every attribute of Officer, Agency found through the search or just some?
  • Indication necessary as to if search result is either an Officer, or Agency?

@DMalone87 DMalone87 linked an issue Apr 23, 2024 that may be closed by this pull request
@hrauniya hrauniya marked this pull request as ready for review April 30, 2024 23:15
@hrauniya hrauniya requested a review from DMalone87 May 6, 2024 21:50
.env.save Outdated
@@ -0,0 +1,7 @@
POSTGRES_USER=postgres
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

bp = Blueprint("search_route", __name__, url_prefix="/api/v1/search")
"""
TODO:
Convert search function to endpoint,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another endpoint you're planning or is this TODO satisfied with this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the TODO is satisfied. Forgot to remove it.

@hrauniya hrauniya marked this pull request as draft June 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] General Name Search Endpoint
2 participants