Start to limit vaccination site data parsing to one place. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hblumberg
commented
Feb 27, 2021
Comment on lines
-71
to
-74
| var sites_latitude = []; | ||
| var sites_longitude = []; | ||
| var available = []; | ||
| var available_latitude = []; | ||
| var available_longitude = []; |
There was a problem hiding this comment.
Just cleaning up these unused arrays while I'm here.
johndeyrup
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, we pass around the vaccination site info exactly as is comes from the database. That means that throughout the frontend, we need to know the names of the fields, what the contents might be, etc.
This PR is a first step towards parsing all of the site data in a single place, and then passing around a parsed object that has some guarantees. (If we ever add a type system, this will be even more helpful!)
Test Plan: