Support new goal files that were added to sftp - issue #180 #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-separate between parsing and saving goal csv and client csv -switch to use collection name ‘testusers’
doub1ejack
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
I haven't had a chance to run this, but if it is working for you I think it's merge-able just the way it is. However I did provide a couple comments and snippets for your consideration too.
Thanks so much Irit! Very excited to have this - I'll follow up with John for more info on that scheduled function, which I believe might be our next step? 🎉
suggestions from Micah Co-Authored-By: Micah Mutrux <micah.mutrux@gmail.com>
suggestions from Micah Co-Authored-By: Micah Mutrux <micah.mutrux@gmail.com>
…nse if these are missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new fields in goal file + split goal file and client file parsing
Known issue: #181