-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rough integration + prep for volunteer meeting #42
rough integration + prep for volunteer meeting #42
Conversation
@RobinHerzig @ShermanMarshall - this is a PR request into a branch that is NOT main. Here's what I did:
For our volunteer meeting, I'm going to take this branch and walk them through the process. But this PR is to get it into the code so others can work on the rest. Since this is going into a new branch that was created, please go ahead and approve then merge this request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I'm curious about App.js though, there's a lot of commented code. It looks like a lot of it is for scrolling animations? I'm guessing it'll either be implemented or removed in the future.
Yea - this was stuff I was working on to make the nav bar work in my other site.
I'll create an issue to clean this up - at least for the code I know can be removed. (Minus the create-react-app code ... at least until we have the volunteer group meeting to show where it once was) Thanks @RobinHerzig UPDATE: See #45 |
In an attempt to have a smoother volunteer meeting to show possible options for converting HTML & CSS to react, I took a stab at #39 ... it took a lot longer than anticipated (about 1 business day) due to how original components were created but attempted to document the process.
This PR is to merge into the branch so it is available for others to work on afterwards.
Known bugs:
This merge incorporates:
They are not finalized - simply brought into a React app for further updates