Fixes PaginationControl upper page limit is always 100 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
galbwe
reviewed
Oct 6, 2021
frontend/src/components/Home.js
Outdated
| @@ -83,25 +83,36 @@ export default function Home() { | |||
|
|
|||
| useEffect(() => { | |||
| let url = `${API_HOST}/leads?page=${page}&perpage=${perpage}`; | |||
| const n_pagesUrl = `${API_HOST}/leads/n_pages`; | |||
There was a problem hiding this comment.
If you check the swagger docs, there is a perpage query parameter to /leads/n_pages. It should save you from redoing the math that is done on the backend.
Suggested change
| const n_pagesUrl = `${API_HOST}/leads/n_pages`; | |
| const n_pagesUrl = `${API_HOST}/leads/n_pages?perpage=${perpage}`; |
frontend/src/components/Home.js
Outdated
| }) | ||
| .then((response) => checkForErrors(response)) | ||
| .then((data) => | ||
| setMaxPages(Math.ceil((data.pages * data.query.perpage) / perpage)) |
There was a problem hiding this comment.
This math is already done on the backend. See my first comment.
Suggested change
| setMaxPages(Math.ceil((data.pages * data.query.perpage) / perpage)) | |
| setMaxPages(data.pages) |
galbwe
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #134
maxpagesis no longer always 100maxpageschanges accordingly with theperpage