Feature/edit vs browse #1757
Merged
Feature/edit vs browse #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: S. Julliand <sebjulliand@gmail.com>
Signed-off-by: S. Julliand <sebjulliand@gmail.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
chrjorgensen
requested changes
Jan 4, 2024
There was a problem hiding this comment.
@sebjulliand Great PR - only a few issues:
- directory uppercase (see code comment)
- filter does not show the library is protected - only when the filter is marked as protected. Could this be done?
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
|
There you go @chrjorgensen :
|
|
@sebjulliand Looking very good and promising! 😍 I will do some more testing tomorrow - before I'll approve this great enhancement. |
chrjorgensen
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
@sebjulliand All is fine - as always with your PR's! 😍
Rebase and merge when appropriate...
Will do! Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resolves #1752
As discussed in https://github.com/orgs/codefori/discussions/1331, browsing/editing support could use a little love. This PR brings some enhancement to address what was discussed:
Opensub-menu replaces the singleBrowseaction in stream files/member's right click menu. The sub-menu offers to explicitly open a streamfile/member read-only or for editing.protected paths: a comma-separated list of libraries and/or IFS paths that will always be opened read-only.Under the hood, all the actions that open a streamfile/member now end up using
code-for-ibmi.openEditablethat holds all the logic for checking if the target should be opened read-only or not. This command has also be enhanced to allow to open a resource and highlight a range in the opened document.Checklist