Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete password when private key is used #1767

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

worksofliam
Copy link
Contributor

Changes

There is a bug with starting the debugger if the user once used a password, but is now using a private key, as the user would never be prompted for the correct password when debugging.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam linked an issue Jan 8, 2024 that may be closed by this pull request
@worksofliam worksofliam requested a review from a team January 8, 2024 21:24
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected! Good job!
But context.secrets function are asynchronous, I'd suggest we await on them everywhere in the extension (here, but there are other places in the extension where await is missing too).

@worksofliam
Copy link
Contributor Author

@sebjulliand Ready for another review - thanks!

Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now!
I added a commit to add await in some other places where the secret store is used, I hope you won't mind 😁
Feel free to merge whenever you want.

@worksofliam worksofliam merged commit 5992be0 into master Jan 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When connecting with private key, remove password from keystore
3 participants