Fix path splitting when opening a member on an IASP #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
sebjulliand
added
the
bug
worksofliam
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
@sebjulliand works for me. My test was adding and removing items from the protected paths list and ensuring the item could be opened and editable when applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1765
The path parsing was incorrect when opening a member located on an iASP. Since this kind of path begins with the iASP, it would return the iASP name as being the library.
This PR adds a method in
Toolsthat will correctly parse the path in any case.Checklist