Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing property on filter objects #1810

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Add missing property on filter objects #1810

merged 1 commit into from
Jan 30, 2024

Conversation

worksofliam
Copy link
Contributor

Changes

Adds missing filterType property on Filter object type.

Checklist

  • have tested my change
  • updated relevant documentation
  • Remove any/all console.logs I added
  • eslint is not complaining
  • have added myself to the contributors' list in CONTRIBUTING.md
  • for feature PRs: PR only includes one feature enhancement.

@worksofliam worksofliam added the bug A confirmed issue when something isn't working as intended label Jan 30, 2024
sebjulliand
sebjulliand approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. That slept past me!

@sebjulliand sebjulliand merged commit de43ec2 into master Jan 30, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/missing_git_type branch January 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worksofliam @sebjulliand