checkObject to support checking member
#1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worksofliam
changed the title
checkObject to support checking member
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
sebjulliand
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
@worksofliam good one; toCl is a nice addition!
I pushed a few commits to fix what I think was a bug and add a test.
I'll let you cross-review it if you will. Then you can merge if you feel like it.
|
@sebjulliand Even better! I love a good test case - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
memberproperty tocheckObjectAPI, allowing us to check if members existtoClstatic method to generate the formatted CL commands. I'd like to move towards using this instead of hardcoding CL strings everywhere.checkObjectAPI usesChecklist
console.logs I added