Fix removing (temp) IFS directories #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrjorgensen
added
the
bug
chrjorgensen
force-pushed
the
fix/remove-directories-fails
branch
from
8d661ff
to
c9309b2
Compare
|
Oh, my master branch was not updated with the latest changes, so I had to force-push after rebase on master and resolving merge-conflicts... Should be okay now... |
|
Looks good to me. I am happy with the merge and there is no major change here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When removing temp directories in IFS, the
rmwould fail because it won't delete directories without the-rflag (recursive):The
-rflag has been added to thermcommands.Checklist