Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore error copying empty member #1851

Merged

Conversation

chrjorgensen
Copy link
Collaborator

Changes

This PR will fix the error occurring, when copying an empty member.

Currently the copy ends with the following errors:

image

and the member list is not updated, even though the new member is created (as empty).

The PR changes the code to only report errors if CPF2869 (Empty member &3 in file &1 in library &2 is not copied) is not among the errors. So now copying an empty member will act exactly like copy members with lines.

Checklist

  • have tested my change

@chrjorgensen chrjorgensen requested a review from a team February 18, 2024 12:21
@chrjorgensen chrjorgensen self-assigned this Feb 18, 2024
@chrjorgensen chrjorgensen added the bug A confirmed issue when something isn't working as intended label Feb 18, 2024
@chrjorgensen
Copy link
Collaborator Author

@sebjulliand I added a property length to IBMiMessages - will it cause any conflicts in other places parsing messages from stderr? I haven't seen any in my tests, but just want to be share (always anxious when changing types... 😆)

Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change works fine, thanks for that!
See my comment about length. It's harmless to add it, but is it useful?

src/api/Tools.ts Outdated Show resolved Hide resolved
src/views/objectBrowser.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 🥰

@sebjulliand sebjulliand merged commit ec399e4 into codefori:master Feb 21, 2024
1 check passed
@chrjorgensen chrjorgensen deleted the fix/ignore-copy-empty-member-error branch March 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants