Add new configuration option to control clearing of diagnostics #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
|
I just had a quick glance at your change - and thought: Shouldn't the control
|
|
@chrjorgensen You're completely right. Thanks for pointing me in the right direction! |
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
chrjorgensen
requested changes
Feb 24, 2024
There was a problem hiding this comment.
@worksofliam LGTM - and works as expected (when your typo is removed). 👍
No new review is required after removal of the typo, you can merge at will.
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
chrjorgensen
approved these changes
Feb 26, 2024
|
@worksofliam Still works... 👍 ...will approve and merge. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the ability to keep diagnostics from other files around when running an Action.
Checklist
console.logs I added