Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed file extension when downloading a single IFS file #1916

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

When downloading a single IFS file, the extension in the File selection dialog is not right (it starts with .) and the dialog doesn't show the files with this extension:
image

This PR removes the . in the extension name and fixes this issue:
image

How to test this PR

  1. With version 2.8.0: try downloading a single file from the IFS browser: extension is wrong, no existing files with the extension are shown.
  2. With the PR checked out: try downloading a single file from the IFS browser: extension is OK, files with the same extension in the folder are shown.

Checklist

  • have tested my change

Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand sebjulliand added the bug A confirmed issue when something isn't working as intended label Mar 6, 2024
@sebjulliand sebjulliand self-assigned this Mar 6, 2024
@sebjulliand sebjulliand changed the title Fixed file extension when downloading singlee IFS file Fixed file extension when downloading single IFS file Mar 6, 2024
@sebjulliand sebjulliand changed the title Fixed file extension when downloading single IFS file Fixed file extension when downloading a single IFS file Mar 6, 2024
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Mac and it continued to work good before and after.

@sebjulliand sebjulliand merged commit d12b218 into master Mar 6, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/ifsSingleDownloadFilename branch March 6, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A confirmed issue when something isn't working as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants