Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow debug batch on *SRVPGM / Allow multiple debug sessions #1989

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Do not allow debug batch on *SRVPGM / Allow multiple debug sessions #1989

merged 3 commits into from
Apr 16, 2024

Conversation

sebjulliand
Copy link
Collaborator

Changes

Fixes #1987
Fixes #1988

This PR fixes the two issues above:

  • It allows for multiple IBM i debug sessions to be run simultaneously
  • It restricts batch debug to *PGM only

How to test this PR

Examples:

  1. Check that Debug as Batch only shows on .PGM objects
  2. Check that the Start Debugging menu shows even if a debug session is already ongoing

Checklist

  • have tested my change

@sebjulliand
Adapt debug error for object type
acd6b25 
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand
Allow multiple IBM i debug sessions at once
5f3f68b 
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
@sebjulliand sebjulliand added the enhancement New feature or request label Apr 16, 2024
@sebjulliand sebjulliand added this to the 2.10.0 milestone Apr 16, 2024
@sebjulliand sebjulliand self-assigned this Apr 16, 2024
worksofliam
worksofliam requested changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like debug as batch was still showing on service programs:

image image

@sebjulliand
Allow debug as batch only on PGM objects
59e605a 
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@sebjulliand
Copy link
Collaborator Author

Duh...I forgot to cherry pick this commit 😅

worksofliam
worksofliam approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@worksofliam worksofliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebjulliand

Much better! Merge whenever you're ready.

image

@sebjulliand sebjulliand merged commit 7948a84 into master Apr 16, 2024
1 check passed
@sebjulliand sebjulliand deleted the fix/multiDebugSRVPGM branch April 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worksofliam worksofliam worksofliam approved these changes

Assignees

@sebjulliand sebjulliand

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

Debug as batch should not be enabled for *SRVPGM Code-for-i only allows one batch debug session
2 participants
@sebjulliand @worksofliam