Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where empty columns were returning as zero. #2007

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix issue where empty columns were returning as zero. #2007

merged 2 commits into from
Apr 25, 2024

Conversation

worksofliam
Copy link
Contributor

@worksofliam worksofliam commented Apr 25, 2024 •
edited

Changes

Fix issue where empty columns were returning as zero.

image

How to test this PR

Examples:

  1. Run the test cases
  2. Make sure the object browser isn't showing '0'

Checklist

  • have tested my change
  • have created one or more test cases
  • updated relevant documentation
  • Remove any/all console.logs I added
  • have added myself to the contributors' list in CONTRIBUTING.md

@worksofliam
Fix issue where empty columns were returning as zero.
39a6b56 
Signed-off-by: worksofliam <mrliamallan@live.co.uk>
@worksofliam worksofliam mentioned this pull request Apr 25, 2024
Closed
@worksofliam worksofliam added this to the 2.10.0 milestone Apr 25, 2024
@sebjulliand
Format
5fa2fa1 
Signed-off-by: S. Julliand <sebjulliand@gmail.com>
sebjulliand
sebjulliand approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@sebjulliand sebjulliand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Work well too. Merge at will!

@worksofliam worksofliam merged commit e294fa4 into master Apr 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebjulliand sebjulliand sebjulliand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@worksofliam @sebjulliand