Don't use library list to validate current library change #2032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seb Julliand <sjulliand@arcadsoftware.com>
chrjorgensen
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #2031
When changing the current library,
CHGCURLIBis run to validate the new current library. If for some reason, the currentcurrent librarycannot be accessed,CHGCURLIBwill fail as the library list is wrong (i.e. it contains a library that cannot be accessed). This prevents the current library from being changed to fix the library list.This PR changes the way
CHGCURLIBis called so it doesn't use the library list.How to test this PR
Examples:
Before the PR, step 5 would fail. With the PR, step 5 runs fine.
Checklist