CourtbotError Functionality Expansion #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of 2
I hope splitting these up makes code review easier.
Functionality
wrap()
utility function to wrap non-CourtbotErrors into CourtbotErrors. (This should allow updating all functions inevents.js
to pipakin's simpler pattern, in Part 2. The issue right now seems to be that unit testing is inconsistently enforcing functionality that's been moved towrap()
. My bad.)Coding Practices
courtbotError
toCourtbotError
--> constructor functions typically start with capital lettersCourtbotError.case
toCourtbotError.casenumber
to avoid potential reserved word conflicts.CourtbotError.case
; however,case
is no longer an enumerable property. (Can we get away with droppingcase
?)