Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gin work with graceful #40

Open
simonlei opened this issue Sep 4, 2014 · 0 comments
Open

Make gin work with graceful #40

simonlei opened this issue Sep 4, 2014 · 0 comments

Comments

@simonlei
Copy link

simonlei commented Sep 4, 2014

Use graceful(https://github.com/stretchr/graceful), we can shutdown the application gracefully.
Gin kill the app in 3seconds(in lib/runner.go), while the connection is still living.
And, the lib/builder.go use go to build binary file, but if the old process is living, the build will fail.
So, I think gin can build the binary to a temp file, then use install instead of copy/mv to overwrite
the binary file. So that We can use gin to work gracefully with graceful.

Of course, install can only used in *nix...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant