-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header quick access item not DSFR compliant anymore #183
Comments
@lsagetlethias Thank you for reporting. @enguerranws Would you have a look... if it's a quick fix. Thanks a lot |
@garronej Sure, I'll check it asap. |
Thanks a lot! |
Well, I've looked into this. The DSFR core js expect that we handle quick access tools duplication by ourselves (which is something that we're already doing) and check it. The check expects that we use the exact same id suffix structure (eg. "my-super-id" -> "my-super-id-mobile", when we're using something like "my-super-id_mobile-${elementIndex}". Both are HTML valid, but the check seems pretty strict.
However, it's just a warning, no urge on this. @garronej what do you think about 1 or 2? |
Hi @enguerranws, I believe option 1 is the best choice. It won't introduce any breaking changes and will offer a quicker resolution. Feel free to change the code, but please keep in mind that we can't remove the IDs. When Eulerian analytics is enabled, it prints a warning for every component that doesn't have an explicit ID. |
Hello @enguerranws, Best, |
Fixed, thanks for reporting! |
Actually fixed nox |
Straight from storybook in Header component page:
Node : 20.6.0
React DSFR : 0.75.5
Chrome : 116.0
The text was updated successfully, but these errors were encountered: