Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tooltip component #190

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
100 changes: 100 additions & 0 deletions src/Tooltip.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
import React, { forwardRef, memo, ReactElement } from "react";
import type { Equals } from "tsafe";
import { assert } from "tsafe/assert";
import { symToStr } from "tsafe/symToStr";
import { useAnalyticsId } from "./tools/useAnalyticsId";

export type TooltipProps = TooltipProps.WithClickAction | TooltipProps.WithHoverAction;

export namespace TooltipProps {
export type Common = {
description: string;
id?: string;
className?: string;
};

export type WithClickAction = Common & {
kind: "click";
children?: ReactElement | string;
};

export type WithHoverAction = Common & {
kind?: "hover";
children: ReactElement | string;
};
}

/** @see <https://components.react-dsfr.codegouv.studio/?path=/docs/components-tooltip> */
export const Tooltip = memo(
forwardRef<HTMLSpanElement, TooltipProps>((props, ref) => {
const { id: id_prop, className, description, kind, children, ...rest } = props;
assert<Equals<keyof typeof rest, never>>();

const id = useAnalyticsId({
"defaultIdPrefix": "fr-tooltip",
"explicitlyProvidedId": id_prop
});

const displayChildren = (
children: ReactElement | string | undefined,
id: string
): ReactElement => {
if (children === undefined) return <></>;
return typeof children === "string" ? (
<span aria-describedby={id} id={`tooltip-owner-${id}`}>
{children}
</span>
) : (
children &&
React.cloneElement(children, {
"aria-describedby": id,
"id": `tooltip-owner-${id}`
})
);
};

return (
<>
{props.kind === "click" ? (
<span ref={ref}>
{children === undefined ? (
<button
className="fr-btn--tooltip fr-btn"
aria-describedby={id}
id={`tooltip-owner-${id}`}
>
Information contextuelle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add transation here ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should i fix the PR ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you are welcome to!
This is not my work, I reopenned the PR because I merged it too rearly

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can see my code review here: #176 (comment)

</button>
) : (
displayChildren(children, id)
)}
<span
className={`fr-tooltip fr-placement ${props.className}`}
id={id}
role="tooltip"
aria-hidden="true"
>
{props.description}
</span>
</span>
) : (
<span ref={ref}>
{displayChildren(children, id)}
<span
className={`fr-tooltip fr-placement ${props.className}`}
id={id}
role="tooltip"
aria-hidden="true"
>
{props.description}
</span>
</span>
)}
</>
);
})
);

Tooltip.displayName = symToStr({ Tooltip });

export default Tooltip;
57 changes: 57 additions & 0 deletions stories/Tooltip.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
import { Tooltip, type TooltipProps } from "../dist/Tooltip";
import { sectionName } from "./sectionName";
import { getStoryFactory } from "./getStory";
import { assert, Equals } from "tsafe/assert";

const { meta, getStory } = getStoryFactory({
sectionName,
"wrappedComponent": { Tooltip },
"description": `
- [See DSFR documentation](https://www.systeme-de-design.gouv.fr/elements-d-interface/composants/infobulle)
- [See source code](https://github.com/codegouvfr/react-dsfr/blob/main/src/Tooltip.tsx)`,
"argTypes": {
"id": {
"control": { "type": "text" },
"description":
"Optional: tootlip Id, which is also use as aria-describedby for hovered/clicked element"
},
"className": {
"control": { "type": "text" },
"description": "Optional"
},
"kind": {
"control": { "type": "select" },
"options": (() => {
const options = ["hover", "click"] as const;

assert<Equals<typeof options[number] | undefined, TooltipProps["kind"]>>();

return options;
})(),
"description": "Optional."
},
"description": {
"control": { "type": "text" }
},
"children": {
"control": { "type": "text" }
}
},
"disabledProps": ["lang"]
});

export default meta;

const defaultOnHoverProps: TooltipProps.WithHoverAction = {
"description": "lorem ipsum",
"children": "Exemple"
};

export const Default = getStory(defaultOnHoverProps);

export const TooltipOnHover = getStory(defaultOnHoverProps);

export const TooltipOnClick = getStory({
"kind": "click",
"description": "lorem ipsum"
});
18 changes: 18 additions & 0 deletions test/types/Tooltip.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { Tooltip } from "../../src/Tooltip";

{
<Tooltip description="lorem ipsum">Exemple</Tooltip>;
}
{
<Tooltip kind="hover" description="lorem ipsum">
Exemple
</Tooltip>;
}
{
<Tooltip kind="click" description="lorem ipsum" />;
}
{
<Tooltip kind="click" description="lorem ipsum">
Exemple
</Tooltip>;
}
Loading