Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make response available from Resource. #46

Merged
merged 4 commits into from
Nov 22, 2013
Merged

Make response available from Resource. #46

merged 4 commits into from
Nov 22, 2013

Commits on Oct 17, 2013

  1. When creating a resource from a request, pass the response to the res… 

    …ource.
    Ben Hamill committed Oct 17, 2013
    Configuration menu
    Copy the full SHA
    184e00e View commit details
    Browse the repository at this point in the history

  2. Proxy status and success? to response object, if we can.

    Ben Hamill committed Oct 17, 2013
    Configuration menu
    Copy the full SHA
    f48b73a View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2013

  1. Fix tests with missing assertions.

    Ben Hamill committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    bb829a5 View commit details
    Browse the repository at this point in the history

  2. Handle non-JSON bodies 

    This is a bit of a hack so that we don't try to parse HTML or plaintext
as JSON when we get back, e.g. a 404. Ideally, we should be looking at
the content type of the header and parsing or not based on that, but
that's for another pull request, for sure.
    Ben Hamill committed Oct 30, 2013
    Configuration menu
    Copy the full SHA
    82fc184 View commit details
    Browse the repository at this point in the history