Feature/configuration support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AWESOME! Thank you! Just one minor thing: in this project we're using Tomdoc to document. Would you mind switching your code to do that? After this I'll run the tests and merge this in right away! :) |
|
@txus oh I'm sorry, I've been writing yard docs for too long and I'm just like a robot and do it automatically now :) so yeah, I'll fix and also add missing docs |
|
No worries :) We've been using Yard not much long ago hehe. |
|
@txus ok I switched the doc format and added more docs |
|
Cool, everything passing! Thanks!! |
txus
pushed a commit
that referenced
this pull request
Feb 15, 2012
Configuration support. Closes #3
|
@txus thanks man! |
|
Wow, awesome pull request!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Guys,
So I quickly added support for configuration via Pelusa::Configuration class. It tries to read
.pelusa.ymlin the current directory and runs stuff based on the config. Initially it only supports disabling/enabling lints and setting custom limits for InstanceVariables and LineRestriction lints. It should be easy to add more options of course.Let me know what you think. I can tweak/improve things based on your feedback.
Cheers!