Parse all options before calling the step files generation #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, well spotted! Could you add a test for it in |
| it "honors the #{feature_path_opt} option" do | ||
| config = Spinach::Config.new | ||
| Spinach.stubs(:config).returns(config) | ||
| cli = Spinach::Cli.new([feature_path_opt,"custom_path", generate_opt]) |
There was a problem hiding this comment.
Line is too long. [82/80]
Space missing after comma.
|
@josepjaume done |
|
Thanks! Nice job :) |
josepjaume
added a commit
that referenced
this pull request
Sep 17, 2014
Parse all options before calling the step files generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command line options should be taken into account by the generator, in particular the -f option. As it is, the generator is called before setting the parameters, ignoring all of them.