Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for multiple reporters, plus a new file reporter #200

Merged
merged 2 commits into from
Jul 10, 2017

Conversation

jabbett
Copy link
Contributor

@jabbett jabbett commented Jul 6, 2017

Per #199, I've attempted to add support for running Spinach with more than one reporter at a time.

spinach -r reporter1,reporter2

As it doesn't make much sense to use two reporters that both output to the screen, I've also included a new FailureFile reporter that, with much inspiration from spinach-rerun-reporter, will output offending scenarios to a file.

It was very useful for me to develop and test the multiple reporter functionality with a working file reporter, but I completely understand if you'd rather I pull the new reporter into a separate PR or an independent repo.

Jonathan Abbett added 2 commits July 6, 2017 13:56
@coveralls
Copy link

coveralls commented Jul 6, 2017

Coverage Status

Coverage increased (+0.2%) to 91.113% when pulling 53adefe on actmd:master into 07290c4 on codegram:master.

Copy link
Member

@oriolgual oriolgual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @jabbett, works for me!

@oriolgual oriolgual merged commit 1fde0a7 into codegram:master Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants