Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.2 fix: remove File.exists? usage #243

Merged
merged 6 commits into from
Feb 9, 2023
Merged

Ruby 3.2 fix: remove File.exists? usage #243

merged 6 commits into from
Feb 9, 2023

Conversation

orien
Copy link
Contributor

@orien orien commented Jan 25, 2023

✍️ Description

Ruby 3.2 has been released! Let's add it to the build matrix along with Ruby 3.1 and 3.0.

✅ Fixes

Resolve use of deprecated File.exists? method. (Replaced with File.exist?.)

File.exists? was removed in Ruby 3.2.

@orien orien changed the title CI: add Ruby 3.0, 3.1, and 3.2 to the test matrix Ruby 3.2 fix: remove File.exists? usage Jan 25, 2023
@orien
Copy link
Contributor Author

orien commented Jan 27, 2023

@ywen what do you think of this proposal?

@orien
Copy link
Contributor Author

orien commented Feb 2, 2023

@josepjaume I'd love to get this project working on Ruby 3.2.

What do you think of this change?

Copy link
Member

@oriolgual oriolgual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!!

@oriolgual oriolgual merged commit 0946544 into codegram:master Feb 9, 2023
This was referenced Feb 9, 2023
@orien orien deleted the ruby3.2 branch February 9, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants