New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add null safety support #26
Conversation
This reverts commit 3595637.
I think the CodeFactor issues are because the service doesn't support Dart null safety features yet... the two errors found make no sense. |
how can i used this ? |
Version 2.0.0 is not on Pub yet due to some breaking changes in theming some picker widgets in Flutter 2.0 , @codegrue is still taking care of these. In the meantime, you can depend on Master by doing something like this:
I would recommend that you hold off on doing this though, you might forget to change it back when the stable version hits Pub or there might be some breaking changes introduced into Master at any point. |
If you guys could test that would be great. Timepicker is as good as it gets without the Flutter team making some changes. I plan to publish on Monday. |
I'll pull upstream and let you know if I find anything. |
Hey,
So as discussed, I've taken care of the changes necessary to support null safety for Flutter 2.0 and Dart version from 2.12 and above.
Changes made:
@required
annotation has been replaced and is not needed for named parameters anymore.required
modifier to any required parameters in widgets and/or functions.String
toString?
).I ran the example app and everything works smoothly including theme switching.
You'd probably need to bump this into a new major version since it requires and SDK upgrade on the user's part.
Resolves #25