Override uId and gId for Tar in test #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not use posix mode because of mTime can have nanoseconds Test can fail on OS with user ID as long, eg: java.lang.IllegalArgumentException: user id '604932503' is too big ( > 2097151 ).
slawekjaranowski
force-pushed
the
tar-posix
branch
from
66cf927
to
659f911
Compare
slawekjaranowski
changed the title
plamentotev
reviewed
Apr 20, 2023
| @@ -809,6 +810,10 @@ public void testZipNonConcurrentResourceCollection() | |||
| { | |||
| final File tarFile = getTestFile( "target/output/zip-non-concurrent.tar" ); | |||
| TarArchiver tarArchiver = (TarArchiver) lookup( Archiver.class, "tar" ); | |||
| // Override uId and gId - in standard mode on OS where uId or gId can have long values creation of tar can fail | |||
| // We can not use posix mode because mTime can have nanoseconds in posix but zip doesn't so assertions can fail | |||
| tarArchiver.setOverrideUid(100); | |||
There was a problem hiding this comment.
This tests the zip file creation from resource collection so not getting the uid/gui from the filesystem should not affect what is asserted. But I wonder how tar tests are not failing then. They should test if the uid is correct.
There was a problem hiding this comment.
In tar tests posix mode is used.
But here also timestamp is compared. Looks like in zip nanoseconds are dropped.
plamentotev
requested review from
plamentotev
and removed request for
plamentotev
plamentotev
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test can fail on OS with user ID as long, eg:
java.lang.IllegalArgumentException: user id '604932503' is too big ( > 2097151 ).
We can not use posix mode because mTime in Tar can have nanoseconds in posix but Zip doesn't so assertions can fail