fixup! Fix PostgreSQL getVersion() logic

codeigniter4 · May 12, 2023 · 98362e6 · 98362e6
1 parent 8064aab
commit 98362e6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/phpstan-baseline.neon.dist b/phpstan-baseline.neon.dist
@@ -65,11 +65,6 @@ parameters:
 			count: 3
 			path: system/Database/MySQLi/PreparedQuery.php
 
-		-
-			message: "#^Strict comparison using \\=\\=\\= between array<string, int|string|null> and false will always evaluate to false\\.$#"
-			count: 1
-			path: system/Database/Postgre/Connection.php
-
 		-
 			message: "#^Access to an undefined property CodeIgniter\\\\Database\\\\BaseConnection\\:\\:\\$schema\\.$#"
 			count: 2

diff --git a/system/Database/Postgre/Connection.php b/system/Database/Postgre/Connection.php
@@ -134,7 +134,11 @@ public function getVersion(): string
 
         $pgVersion = pg_version($this->connID);
 
-        return isset($pgVersion['server']) ? $this->dataCache['version'] = $pgVersion['server'] : false;
+        if (! isset($pgVersion['server'])) {
+            return 'PostgreSQL 7.4 or lower';
+        }
+
+        return $this->dataCache['version'] = $pgVersion['server'];
     }
 
     /**