Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation on exists database before created #1759

Closed
ghost opened this issue Feb 24, 2019 · 1 comment
Closed

Add validation on exists database before created #1759

ghost opened this issue Feb 24, 2019 · 1 comment
Milestone
4.0.*

Comments

@ghost
Copy link

ghost commented Feb 24, 2019

CodeIgniter don't content any methods of checking of database exists.
Please add validation on exists database before created to Forge Class by default:

protected $createDatabaseStr = 'CREATE DATABASE IF NOT EXISTS %s';
@lonnieezell
Copy link
Member

You're right, it currently doesn't, and never has if memory serves correctly. I think this is a good addition, but not going to happen until after 4.0 final, since we've hit a feature freeze until release.

@lonnieezell lonnieezell added this to the 4.0.1? milestone Feb 25, 2019
@oleg1540 oleg1540 mentioned this issue Jul 21, 2019
Closed
5 tasks
oleg1540 added a commit to oleg1540/CodeIgniter4 that referenced this issue Jul 21, 2019
@oleg1540
codeigniter4#1759 - Added validation on exists database before create…
c2699b5 
…d for MySQLi and Postgre
@oleg1540 oleg1540 mentioned this issue Jul 21, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.*
Development

No branches or pull requests
1 participant
@lonnieezell