Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller Test / Feature Testing output issues #1767

Closed
lonnieezell opened this issue Feb 28, 2019 · 7 comments · Fixed by #1977
Closed

Controller Test / Feature Testing output issues #1767

lonnieezell opened this issue Feb 28, 2019 · 7 comments · Fixed by #1977
Assignees

Comments

@lonnieezell
Copy link
Member

The ControllerTester currently only gets a body in the result when the content is echo() in the controller. Using a return here doesn't work.

However - the opposite problem exists with FeatureTesting.

@jim-parry jim-parry added this to the 4.0.0-beta.2 milestone Mar 5, 2019
@jim-parry
Copy link
Contributor

ControllerTester problem fixed by 1848 & 1855.
Feature testing up shortly.

@jim-parry jim-parry self-assigned this Mar 25, 2019
@jim-parry
Copy link
Contributor

@lonnieezell The user guide suggests that withRoutes() takes an array of mappings, but the FeatureTestCase is using an array of triplet arrays (http verb | add, URI pattern, and routing destination.

Which should it be?

@lonnieezell
Copy link
Member Author

@jim-parry Looks like docs are wrong in that case. Should be able to specify the HTTP verb to use like implemented.

@jim-parry
Copy link
Contributor

ok, thanks. i will update the docs as part of this

@jim-parry
Copy link
Contributor

There is a bigger problem underlying this, with testing routing rules not sticking.
Working on it.

@lonnieezell
Copy link
Member Author

Uh-oh! Need any help on that?

@jim-parry
Copy link
Contributor

The problem I am experiencing is that the routecollection is not being updated/replaced by second & subsequent tests in the FeatureTestTestCase. I will push what I have as a WIP -maybe you can see something I am missing, thanks.

jim-parry added a commit to jim-parry/CodeIgniter4 that referenced this issue Apr 3, 2019
@jim-parry jim-parry modified the milestones: 4.0.0-beta.2, 4.0.0-beta.3 Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants