Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation mistake: Model::save does not return a boolean only #1780

Closed
hwiesmann opened this issue Mar 1, 2019 · 1 comment
Closed

Documentation mistake: Model::save does not return a boolean only #1780

hwiesmann opened this issue Mar 1, 2019 · 1 comment

Comments

@hwiesmann
Copy link

Describe the bug
The documentation states that Model::save returns a boolean value. This is not true. It also may return the ID of an inserted record and therefore an integer type.

CodeIgniter 4 version
CodeIgniter4 Alpha 2

Affected module(s)
Model
@jim-parry jim-parry added this to the 4.0.0-beta.2 milestone Mar 5, 2019
bangbangda added a commit to bangbangda/CodeIgniter4 that referenced this issue Mar 11, 2019
@bangbangda
Fix save method return value. Fixex codeigniter4#1780
87ea9eb
@jim-parry
Copy link
Contributor

Closed by #1808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hwiesmann @jim-parry