Bug: Models, useSoftDeletes not found in findAll

[Daniel-Monroy]

Bug
When obtaining records using findAll () and using useSoftDeletes in true, the method returns all records when it can return while $ this-> deletedField is null

CodeIgniter 4 version
4.0.2

Affected module(s)
Codeigniter\Model

[musmanikram]

@danielMonroy96 Can you post some code. Because i checked tests and they worked as expected.
If you can post some code, will help to fix this

[Daniel-Monroy]

This is my code.

[Daniel-Monroy]

Thanks for your help, in the first consultation it does not give me the expected results

[nyufeng]

deleted_at default value?

[Daniel-Monroy]

My model!

[nyufeng]

i want see you table structure. and row line.
ex:

[Daniel-Monroy]

thanks

[nyufeng]

everything is normal.

[Daniel-Monroy]

I'll try updating CI, because the problem persists

[arif-rh]

@danielMonroy96 If I see your code, It seems the issue is not from the Model but in your logic code

I have tried to reproduce the issue but everything seem right. So can you confirm again, is your logic code is right?

[Daniel-Monroy]

Apparently yes, I have already compared my code with colleagues and it works fine! Maybe it's my environment, thanks for your help and response Good day!! El vie., 6 mar. 2020 a las 17:47, Arif RH (<notifications@github.com>) escribió:

…

@danielMonroy96 <https://github.com/danielMonroy96> If I see your code, It seems the issue is not from the Model but in your logic code [image: logic flow] <https://user-images.githubusercontent.com/2386359/76130981-42e91880-603f-11ea-9b79-6a8faeee0a8b.png> I have tried to reproduce the issue but everything seem right. So can you confirm again, is your logic code is right? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2658?email_source=notifications&email_token=AK37UMSRHTMTINQYEQHSMBDRGGDQHA5CNFSM4K733RQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEODGTDQ#issuecomment-596011406>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AK37UMRC77LSZ6JECX72MATRGGDQHANCNFSM4K733RQQ> .

[MGatner]

@danielMonroy96 is this issue resolved? If so feel free to close it.

[leutamo]

Hi everyone, i have same problem. i read the answer from Instrye, and all works fine.
the problem its in the Database fields, this suppose that not work's with int values(deleted_at)?.
well, with datetime in database works pretty :)
Thanks all!! only here found the answer thanks Instrye!!! you rock'ss!!
best regards!

[michalsn]

This seems like resolved.

[JJohanGH]

Para resolver este problema, yo lo hice de esta manera:
entre a vendor\codeigniter4\framework\system\Model.php o sea el modelo que estas extendiendo
corregí la function findAll al igual que find:

`
public function findAll(int $limit = 0, int $offset = 0)
{
$builder = $this->builder();

	if ($this->tempUseSoftDeletes === true)
	{
		#$builder->where($this->table . '.' . $this->deletedField, null); -- JJohan 20201028 
		$builder->where($this->table . '.' . $this->deletedField, null);
	}

	$row = $builder->limit($limit, $offset)
			->get();

	$row = $row->getResult($this->tempReturnType);

	$eventData = $this->trigger('afterFind', ['data' => $row, 'limit' => $limit, 'offset' => $offset]);

	$this->tempReturnType     = $this->returnType;
	$this->tempUseSoftDeletes = $this->useSoftDeletes;

	return $eventData['data'];
}

`

[tanviet12]

findAll() will not working when:

• $useSoftDeletes = true

• deleted_at column with data type is timestamp.

Run this query to change deleted_at from timestamp to datetime:

alter table `your_table` modify column `deleted_at` datetime DEFAULT NULL;