Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: open path /0 at uri got error "Class Home does not exist" on development environment #2716

Closed
samsonasik opened this issue Mar 17, 2020 · 1 comment · Fixed by #2717
Closed

Bug: open path /0 at uri got error "Class Home does not exist" on development environment #2716

samsonasik opened this issue Mar 17, 2020 · 1 comment · Fixed by #2717
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@samsonasik
Copy link
Member

samsonasik commented Mar 17, 2020 •
edited
Loading

When on development environment, open page eg: http://ci4.local/0 got "Class Home does not exist" and when open at production environment it doesn't has error, but show the Home page, I think it should be 404 instead.

CodeIgniter 4 version
4.0.2

Expected behavior, and steps to reproduce if appropriate

On development and production env, it should be 404 page.

Context

  • OS: MacOS
  • Web server Apache
  • PHP version 7.4
@samsonasik samsonasik added the bug Verified issues on the current code behavior or pull requests that will fix them label Mar 17, 2020
@samsonasik
Copy link
Member Author

also, I can't register route "/0", I think it related with "empty($path)" check in the URI class which 0 is also an empty. It should be compare to empty string instead.

samsonasik added a commit to samsonasik/CodeIgniter4 that referenced this issue Mar 17, 2020
@samsonasik
[wip] fix codeigniter4#2716 open path /0 got error on development and…
8127cb2 
… 200OK on production, which should be 404
@samsonasik samsonasik mentioned this issue Mar 17, 2020
Merged
2 tasks
lonnieezell added a commit that referenced this issue Mar 18, 2020
@lonnieezell
Merge pull request #2717 from samsonasik/fix-2716
813ab59 
Bug Fix: Fix #2716 open path /0 got error on development and 200OK on production, which should be 404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
1 participant
@samsonasik