Bug: Namespacing of app/Config folder vs. app/Controller

[samfullman]

I've noticed what appears to be an inconsistency in CodeIgniter4 namespacing and wanted to enquire about the logic of it.

In CI4 namespacing, the system folder is CodeIgniter (which makes sense), and class files in all folders and subfolders in system reliably have the namespace
CodeIgniter\Folder[\Subfolder].

However in the app folder, which has a paucity of class files starting out, it's not so uniform: the namespace for files in the Config folder is simply Config, but the namespace for class files in Controller is App\Controller.

Is there an intentional reason for this? It seems inconsistent to me. It stands to reason that the app/Config folder files should also have the namespace App\Config

[lonnieezell]

This is because the APP_NAMESPACE can be changed. We ran into issues early on where if App namespace was changed the system could not load up the config files and died. I don't recall any additional specifics around it as that was a couple of years ago. But it's a safety feature for the framework so it can always find it's config files. Probably less crucial now that the config() helper exists and can search through all namespaces, but we can't change it now without it being a BC break and it's way too early for a v5 release. :)

Something we can definitely take a look at down the road, though, to see if it makes sense now.

[samfullman]

Thanks Lonnie, coincidentally I'm reviewing an article by you on the Modules portion of CI4 - http://blog.newmythmedia.com/blog/show/2016-03-15_Modules_in_CodeIgniter_4 I have an idea for a contribution which I need to review the CONTRIBUTING.md on so give me about a week to have some time with work schedule currently. Thanks, I enjoy what I've seen in CI4. Sam

…

On Wed, Apr 15, 2020 at 12:42 PM Lonnie Ezell ***@***.***> wrote: Closed #2826 <#2826>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2826 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHXYETQBRBYFSLMULUM7DLRMXWXTANCNFSM4MIPQUFA> .

-- *Samuel Fullman* (512) 210-4814 M • (512) 754-7927 H www.GitHub.com/CompassPointMedia

[lonnieezell]

Hey Sam - I look forward to the seeing your contributions!

[samfullman]

Hey Lonnie, question: I see there's a `master` branch on the CodeIgniter4 repo which I didn't see before. Up to now I've been pulling in develop into my code to keep current, assuming develop is going to have the latest things, and that eventually I'll want to contribute what I'm working on to the community (more on that soon - busy life but I'm still setting aside cycles to get this done). Is this a correct assumption? Or should I be merging master vs. develop. I'm assuming I should merge develop. Thanks

…

On Wed, Apr 15, 2020 at 9:38 PM Lonnie Ezell ***@***.***> wrote: Hey Sam - I look forward to the seeing your contributions! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2826 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHXYEUUOWZOEXCQLLOI65DRMZVSLANCNFSM4MIPQUFA> .

-- *Samuel Fullman* (512) 210-4814 M • (512) 754-7927 H www.GitHub.com/CompassPointMedia

[lonnieezell]

Master branch is pushed to when a new release happens (4.0.4, etc). To stay up to date with the latest changes (but take on the risk of in-development and potentially unstable code) use the develop branch.

[samfullman]

Thanks Lonnie, BTW your blog was a good one, quite understandable, looks like it's down. Of course Google still has a version/cache of it, which I found here: http://webcache.googleusercontent.com/search?q=cache:UsiLD3YY2ZEJ:blog.newmythmedia.com/blog/show/2016-03-15_Modules_in_CodeIgniter_4+&cd=1&hl=en&ct=clnk&gl=us Sam

…

On Fri, Nov 27, 2020 at 10:46 PM Lonnie Ezell ***@***.***> wrote: Master branch is pushed to when a new release happens (4.0.4, etc). To stay up to date with the latest changes (but take on the risk of in-development and potentially unstable code) use the develop branch. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2826 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADHXYETGPOA7LCVUWGSQH6DSSB6DXANCNFSM4MIPQUFA> .