Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: DateHelperTest::testNowSpecific depends on time #5492

Closed
kenjis opened this issue Dec 21, 2021 · 2 comments · Fixed by #6753
Closed

Bug: DateHelperTest::testNowSpecific depends on time #5492

kenjis opened this issue Dec 21, 2021 · 2 comments · Fixed by #6753
Labels
testing Pull requests that changes tests only

Comments

@kenjis
Copy link
Member

kenjis commented Dec 21, 2021 

There was 1 failure:

1) CodeIgniter\Helpers\DateHelperTest::testNowSpecific
Failed asserting that 4 is equal to 1 or is less than 1.

/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/CIUnitTestCase.php:461
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Helpers/DateHelperTest.php:35

https://github.com/codeigniter4/CodeIgniter4/runs/4593459157?check_suite_focus=true
@kenjis kenjis added the testing Pull requests that changes tests only label Dec 21, 2021
fpoy added a commit to fpoy/CodeIgniter4 that referenced this issue Oct 14, 2022
@fpoy
Bug: DateHelperTest::testNowSpecific depends on time
825c59d 
Fixes codeigniter4#5492
@fpoy fpoy mentioned this issue Oct 14, 2022
Closed
5 tasks
@kenjis
Copy link
Member Author

kenjis commented Oct 25, 2022 

1) CodeIgniter\Helpers\DateHelperTest::testNowSpecific
Failed asserting that 4 is equal to 1 or is less than 1.

/home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/CIUnitTestCase.php:478
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Helpers/DateHelperTest.php:36
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3317017866/jobs/5479434095

@kenjis kenjis mentioned this issue Oct 25, 2022
Merged
4 tasks
@kenjis
Copy link
Member Author

kenjis commented Apr 2, 2024

Closed by #6753

@kenjis kenjis closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing Pull requests that changes tests only
Projects
None yet
Milestone
No milestone
1 participant
@kenjis