Release build script #1231
Merged
Release build script #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narfbg
reviewed
Sep 22, 2018
|
I plan to merge this, to get the ball rolling, but to only use the release branch building part for the first release - doing the deployment manually to make sure I didn't forget or mess up anything. The script can be adjusted once we see how that works. One thing unclear - whether the script will make a pre-release or a full release, from github's perspective. Do I need to do something like the solution here, with a curl post inside the script? |
|
@jim-parry that sounds like a good idea. Nice work, btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And .... here we go. This is the first crack at the release builder.
It is tested to the "are we there yet?" point, but I am reluctant to proceed with the next level of testing until someone else has taken a peek, to make sure I didn't do somthing stupid.