Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP use $paths->systemDirectory in public/index.php #1457

Merged
merged 3 commits into from
Nov 29, 2018

Conversation

samsonasik
Copy link
Member

So it reduce manual change when changing system directory.

Checklist:

  • Securely signed commits

@jim-parry
Copy link
Contributor

This will work for now, but the solution will be different once we get the the simplified distributions in place.
I would like to defer this until then, and hopefully enlist your help making sure the distrubtions work as intended.

@jim-parry jim-parry changed the title use $paths->systemDirectory in public/index.php WIP use $paths->systemDirectory in public/index.php Nov 14, 2018
@samsonasik samsonasik force-pushed the use-path-systemDirectory branch 2 times, most recently from efade10 to 9f1b02e Compare November 19, 2018 07:09
@samsonasik
Copy link
Member Author

@jim-parry mergeable?

@jim-parry
Copy link
Contributor

Yes. This makes one less file for my script to change :)

@jim-parry jim-parry merged commit db77587 into codeigniter4:develop Nov 29, 2018
@samsonasik samsonasik deleted the use-path-systemDirectory branch November 29, 2018 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants