WIP Update Router.php

[sugenganthos]

Example my routes def:
`
$routes->get('/search', 'Home::search'); // def 1

$routes->get('/(:segment)/(:segment)/{locale}','Product::details/$1/$2'); // def 2

$routes->get('/(:segment)/(:segment)','Product::details/$1/$2'); // def 3

$routes->get('/(:segment)','Product::category/$1'); // def 4
`

My url:
uri 1 : http://mysite.test/clothes should go to Product::category('clothes')
uri 2 : http://mysite.test/clothes/tshirt should go to Product::details('clothes','tshirt')
uri 3 : http://mysite.test/clothes/tshirt/id should go to Product::details('clothes','tshirt') with indonesian locale

Error found, it says "undefined offset"

First bug:
After evaluating def 2 , $localeSegment has array index. Then evaluating def 3. That value is retained and causes out-of-range index of $this->detectedLocale = $temp[$localeSegment];
So $localeSegment needs to be reset every iteration. I don't know if this a bug or intended.

Second bug:
I separate $localeSegment = array_search('{locale}', explode('/', $key)); just for debugging purpose.
Becomes:

$exp = explode('/', $key); $localeSegment = array_search('{locale}', $exp);

When evaluating def 2 which is '/(:segment)/(:segment)/{locale}'
Turns out the $exp = [ "([^" , "]+)" , "([^" , "]+)" , "{locale}"] (5 elements) instead of $exp = [ "([^/]+)" , "([^/]+)" , "{locale}"] (3 elements)
So it has error because '/' in regex takes into account for explode() function.

$temp = (explode('/', $uri)); $this->detectedLocale = $temp[$localeSegment];

On uri 3,
Exploding $uri results 3 elements, but exploding matched $key results 5 elements --> "undefined offset"

I see 3 possible solution for this:

First, my used solution,
replacing regex temporary with 'x' just to remove '/' before exploding. I think this is not good solution because to many step ( placeholder -> regex -> dummy string -> regex again). But it works for me until now.

Second,
Exploding and finding {locale} index is done before replacing placeholder with regex. So '/' will not mess with explode(). I don't know how to implement this. CI4 is a large framework.

Third,
using preg_split instead of explode to split keys only with '/' outside parenthesis. So key "([^/]+)/([^/]+)/{locale}" will results [ "([^/]+)" , "([^/]+)" , "{locale}" ]

[sugenganthos]

temporary replacing regex with 'x' just to remove '/' character

[jim-parry]

This might work for your usecase, but dpesn't feel right for the general usecase. I agree that your other two proposed solutions would be better. The second suggestion, handling locale separately form the rest of the URI, sounds most promising.

Would another workaround be to put the locale in the second segment if it is to be used?

[sugenganthos]

That is good to place locale there. But some user just remove locale segment (they rely on website's link to change locale instead on typing on the address bar) and website rely on default locale.

So my usecase is put locale segment on last segment

[jim-parry]

Maybe the routing needs to handle the special case the the locale might be the last segment instead of the first one then? Actually, it needs to woek either way.
Hmm - this might provide the basis for a unit test to expose the problem :)
Either way, simply replacing {locale} with x doesn't seem right :-/

[sugenganthos]

Sure it not right :( , it is just quick hack. In the end, I just use GET variable to change locale and save it to visitor's cookie. My routing has assign 0 - 3 segment already, so locale segment can misinterpret as path segment.
If locale always shown on 4th segment, that will be easier todo. Unfortunately, path with 2 segment can also have {locale} and misinterpret as 3rd segment
This is the cost to make url looks memorable :)

In the end, I just remove routing with {locale} and change locale using GET instead and save it to visitor's cookie

[sugenganthos]

Anyway, if {locale} segment gets overlap with path / parameter segment, that is developer problems, nothing todo with framework. Naturally it will get misinterpret, which comes first.
{locale} may misinterpret as another regular segment.
or ordinary segment misinterpret as locale code (surely will fallback to default locale, but the regular segment won't get executed)

[atishhamte]

@lonnieezell, its done. Could you please close this