use app_timezone() in Response and DownloadResponse when app timezone defined #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natanfelles
reviewed
Nov 27, 2018
| @@ -269,7 +269,7 @@ public function getReason(): string | |||
| */ | |||
| public function setDate(\DateTime $date) | |||
| { | |||
| $date->setTimezone(new \DateTimeZone('UTC')); | |||
| $date->setTimezone(new \DateTimeZone(app_timezone() ?? 'UTC')); | |||
|
|
|||
| $this->setHeader('Date', $date->format('D, d M Y H:i:s') . ' GMT'); | |||
There was a problem hiding this comment.
If the app_timezone() is America/Sao_Paulo it is not GMT. See also.
|
ok, i’m closing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Application timezone defined in configuration, it will read the timezone defined instead of 'UTC'.
Checklist: