allows to set empty html attr #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as for now there was no way to set empty attribute like required or autofocus
better to use is_bool here (instead of my previous solution which was $value !== false) , that way we left more flexibility for users for pre/post process attributes
|
Looks good, but we need some tests added to test that feature please. |
null, false, true, string, empty string, 0, 1
|
@lonnieezell : done. |
lonnieezell
reviewed
Dec 3, 2018
| public function testFormParseFormAttributesFalse() | ||
| { | ||
| $expected = 'disabled '; | ||
| $this->assertEquals($expected, parse_form_attributes(['disabled' => false], [])); |
There was a problem hiding this comment.
Shouldn't a false setting on a value make it so that it does not appear in the attributes list?
There was a problem hiding this comment.
I thought we have more flexibility outside form helper function if we will treat true as well as false in the same way.
However I know what you are thinking so I am open to changes.
There was a problem hiding this comment.
That's fair. I can live with that, and it's still valid HTML, so I'm good. Will merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
as for now there was no way to set empty attribute like required or autofocus
Each pull request should address a single issue, and have a meaningful title.