New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use .gitkeep instead of .gitignore in Database/Seeds directory #1549

Merged

jim-parry merged 1 commit into codeigniter4:develop from samsonasik:gitkeep-in-seed

Nov 29, 2018

Member

samsonasik commented Nov 28, 2018

To be consistent with other empty directories.

Checklist:

Securely signed commits


          use .gitkeep in Database/Seeds directory instead of .gitignore

393260b

Contributor

jim-parry commented Nov 28, 2018

Agreed. The empty .gitignore is being used as a placeholder, which by convention should be .gitkeep

jim-parry approved these changes

View reviewed changes

jim-parry merged commit 633e291 into codeigniter4:develop

samsonasik deleted the gitkeep-in-seed branch

November 29, 2018 05:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment