Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site_url generate invalid url #1588

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

puschie286
Copy link
Contributor

@puschie286 puschie286 commented Dec 6, 2018

Description
site_url should add / only if a path is provided
-> fix debugbar loading url
.../index.php/?debugbar -> .../index.php?debugbar

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

Signed-off-by: Christoph Potas <christoph286@googlemail.com>
~ adjust tests

Signed-off-by: Christoph Potas <christoph286@googlemail.com>
@lonnieezell lonnieezell merged commit 9eac5f3 into codeigniter4:develop Dec 7, 2018
@puschie286 puschie286 deleted the fixSiteURLBackslash branch December 7, 2018 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants