Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up \Config\Services in Common.php #1601

Merged
merged 1 commit into from
Dec 10, 2018

Conversation

samsonasik
Copy link
Member

Config\Services already in use statement.

Checklist:

  • Securely signed commits

@jim-parry
Copy link
Contributor

I'm fine with this

@lonnieezell
Copy link
Member

This should be fine. The only issue I can think of is when people do a copy/paste to app/Config/Services so they can override the method it's possible (though hopefully unlikely) they'll have a different services file used in that class.

@jim-parry do you think this is worth keeping the full namespace in the class for? It shouldn't come up much, since all of the features expect you to call on Config\Services.

@jim-parry
Copy link
Contributor

I think that "synching" app after a new release is a different kettle of fish, and needs to be addressed separately.
This PR as it sits is good to go.

@jim-parry jim-parry merged commit edc9374 into codeigniter4:develop Dec 10, 2018
@samsonasik samsonasik deleted the cleanup-config-service branch December 11, 2018 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants