New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New method Find Column w.r.t. #1619 #1861
Conversation
I believe the purpose of the originally proposed method was to return an array of the values only, at least when a single column was asked for, like:
That makes it easy to grab a column of values and then immediately use it for a whereIn, or whatever. |
I kept the purpose is to shorthand the query, where you can get the response in the format of object or array when you pass single and multiple columns. |
My personal feeling is that if all it does is provide a shorthand way to get rid of doing With that in mind - I think it should always return an array of the actual values. If need be, restrict it to a single column name. |
No problem. I will make the necessary changes |
Does the second parameter is required in the method? or we should strictly keep it as a result set of all values under the column without where condition. |
I have done the changes for single column input along with exception handling |
@lonnieezell and @jim-parry, any changes required in this PR? |
Changes done according to array_column |
@lonnieezell any changes required here? |
Looks good! Thanks. |
W.r.t #1619, correction in the codes and introduced test cases as well
Its a shorthand query.
Checklist: