Mysql connection issue with MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT #1219

[atishhamte]

Mysql connection issue with MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT #1219

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• Conforms to style guide

[nControl88]

Hi @atishamte. I realise this PR has already been committed a while ago. I noticed an issue with the current code, which you might be able to change.

CodeIgniter4/system/Database/MySQLi/Connection.php

Lines 162 to 165 in 1d40479

	elseif (defined('MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT') && version_compare($this->mysqli->client_info, '5.6', '>='))
	{
	$client_flags += MYSQLI_CLIENT_SSL_DONT_VERIFY_SERVER_CERT;
	}

The version_compare compares the local version of mysql with the condition. This might not work out if using an external database server. Would you be able to change this to a conditional setting?