Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseBuilder Corrections #1902

Merged
merged 18 commits into from
Apr 3, 2019
Merged

BaseBuilder Corrections #1902

merged 18 commits into from
Apr 3, 2019

Conversation

atishhamte
Copy link
Contributor

@atishhamte atishhamte commented Mar 30, 2019 •
edited
Loading

Some BaseBuilder corrections like,

  • Undefined variables defined.
  • Removed unnecessary declarations
  • Typos corrections

Checklist:

  • Securely signed commits
  • Component(s) with PHPdocs
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@atishhamte atishhamte changed the title BaseBuilder Corrections WIP BaseBuilder Corrections Mar 31, 2019
@atishhamte atishhamte changed the title WIP BaseBuilder Corrections BaseBuilder Corrections Mar 31, 2019
@atishhamte atishhamte changed the title BaseBuilder Corrections WIP BaseBuilder Corrections Mar 31, 2019
@atishhamte atishhamte changed the title WIP BaseBuilder Corrections BaseBuilder Corrections Mar 31, 2019
lonnieezell
lonnieezell requested changes Apr 1, 2019
View reviewed changes
system/Database/BaseBuilder.php Outdated Show resolved Hide resolved
system/Database/BaseBuilder.php Outdated Show resolved Hide resolved
system/Database/BaseBuilder.php Outdated Show resolved Hide resolved
system/Database/Postgre/Builder.php Outdated Show resolved Hide resolved
@atishhamte
Copy link
Contributor Author

@lonnieezell, Changes are done.

@atishhamte
Copy link
Contributor Author

Any update on this @lonnieezell

@atishhamte
Copy link
Contributor Author

@lonnieezell @jim-parry, why the last commit didn't build by Travis CI?

@jim-parry
Copy link
Contributor

There are conflictrs that need to be resolved, would be my guess.

@atishhamte
Copy link
Contributor Author

Thanks for starting the build. I have done with all the changes.

@lonnieezell lonnieezell merged commit 1c87d56 into codeigniter4:develop Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lonnieezell lonnieezell lonnieezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atishhamte @jim-parry @lonnieezell